Backport make_release fix for creating the build directory as non-root to v1.9 #4776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless we call `ensure_build_dir`, the build directory will be created inside the Docker container as root and subsequent builds will fail. Fix this by making sure exists before building with proper permissions. (cherry picked from commit 63749ec) Signed-off-by: Babis Chalios <[email protected]>
bchalios
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.9 #4776 +/- ##
=================================================
Coverage 84.34% 84.34%
=================================================
Files 249 249
Lines 27461 27461
=================================================
Hits 23162 23162
Misses 4299 4299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
approved these changes
Sep 2, 2024
Manciukic
approved these changes
Sep 2, 2024
bchalios
merged commit d3b02e0
into
firecracker-microvm:firecracker-v1.9
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix
./tools/devtool make_releaseby making sure exists before building with proper permissions.(cherry picked from commit 63749ec)
Reason
Unless we call
ensure_build_dir, the build directory will be created inside the Docker container as root and subsequent builds will fail.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.