Add new benches #4783
Merged
Add new benches #4783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4783 +/- ##
=======================================
Coverage 84.34% 84.34%
=======================================
Files 249 249
Lines 27460 27460
=======================================
Hits 23160 23160
Misses 4300 4300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
reviewed
Sep 5, 2024
ShadowCurse
force-pushed
the
add_benches
branch
from
f19fb54 to
af7649c
Compare
9 tasks
ShadowCurse
force-pushed
the
add_benches
branch
from
af7649c to
7529949
Compare
roypat
reviewed
Sep 5, 2024
ShadowCurse
force-pushed
the
add_benches
branch
from
7529949 to
47d4ec5
Compare
roypat
reviewed
Sep 5, 2024
roypat
reviewed
Sep 5, 2024
ShadowCurse
force-pushed
the
add_benches
branch
from
47d4ec5 to
bf444f3
Compare
bchalios
reviewed
Sep 6, 2024
ShadowCurse
force-pushed
the
add_benches
branch
from
bf444f3 to
980f987
Compare
bchalios
reviewed
Sep 6, 2024
ShadowCurse
force-pushed
the
add_benches
branch
from
980f987 to
216d823
Compare
Add benchmarks for `Queue` and `DesciptorChain` objects. This will allows us to see performance difference with changes introduced to the queue in the future. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
add_benches
branch
from
216d823 to
ed9ed7d
Compare
bchalios
previously approved these changes
Sep 6, 2024
Add bench for `Request::parse` method. This will allow us to track performance of this method. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
add_benches
branch
from
ed9ed7d to
df4cd12
Compare
roypat
approved these changes
Sep 6, 2024
bchalios
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add benchmarks for Queue::pop/add_used, DescriptorChain::next_descriptor and Request::parse(from virtio block)
Reason
We want to track most used methods in device emulation to see performance gains/regressions.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.