Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Sep 6, 2024

The kani test does not use the pre-built firecracker binaries, as kani does static analysis, and does not execute binaries. Thus, do not have the kani test block on compilation finishing.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

The kani test does not use the pre-built firecracker binaries, as kani
does static analysis, and does not execute binaries. Thus, do not have
the kani test block on compilation finishing.

Signed-off-by: Patrick Roy <[email protected]>
@roypat
Copy link
Contributor Author

roypat commented Sep 6, 2024

image
example of how this'll look (had to put a temporary dummy commit that touches rust code to be able to trigger the kani step)

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.34%. Comparing base (50ad94b) to head (a73b3a3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4785   +/-   ##
=======================================
  Coverage   84.34%   84.34%           
=======================================
  Files         249      249           
  Lines       27460    27460           
=======================================
  Hits        23160    23160           
  Misses       4300     4300           
Flag Coverage Δ
5.10-c5n.metal 84.56% <ø> (ø)
5.10-m5n.metal 84.55% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 83.83% <ø> (ø)
5.10-m6g.metal 80.91% <ø> (ø)
5.10-m6i.metal 84.54% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.91% <ø> (ø)
6.1-c5n.metal 84.56% <ø> (ø)
6.1-m5n.metal 84.54% <ø> (ø)
6.1-m6a.metal 83.84% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 80.90% <ø> (-0.01%) ⬇️
6.1-m6i.metal 84.54% <ø> (ø)
6.1-m7g.metal 80.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat merged commit 599c48c into firecracker-microvm:main Sep 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants