test: do not build firecracker before running kani #4786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kani has no use for pre-built binaries, and I'm fairly certain it cannot even reuse the build artifacts due to using a different toolchain. So pass `--no-build` to `devtool test` when running the kani test to safe a few more minutes there. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4786 +/- ##
==========================================
- Coverage 84.34% 84.32% -0.02%
==========================================
Files 249 249
Lines 27460 27457 -3
==========================================
- Hits 23160 23154 -6
- Misses 4300 4303 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
See https://buildkite.com/firecracker/firecracker-pr/builds/11026#0191c77e-61a3-4285-81ee-7bc9381cc53a as an example of it no longer building firecracker (again, I had to use a dummy commit to get the kani test to trigger) |
roypat
force-pushed
the
kani-no-build
branch
from
214c8a8 to
eb33072
Compare
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Sep 6, 2024
bchalios
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kani has no use for pre-built binaries, and I'm fairly certain it cannot
even reuse the build artifacts due to using a different toolchain. So
pass
--no-buildtodevtool testwhen running the kani test to safe afew more minutes there.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.