Pin 6.1 buildkite agents. #4794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
previously approved these changes
Sep 10, 2024
Latest 6.1 introduced a regression in the parsing of VirtIO headers for the network device. This causes failures in the TX path, where Firecracker fails to write network frames in the TAP device. Pin the buildkite agents with 6.1 kernel to the latest known good version. Signed-off-by: Babis Chalios <[email protected]>
bchalios
added
the
Status: Awaiting review
roypat
approved these changes
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4794 +/- ##
=======================================
Coverage 84.31% 84.31%
=======================================
Files 249 249
Lines 27522 27522
=======================================
Hits 23206 23206
Misses 4316 4316
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Pin 6.1 kernel buildkite agents to previous kernel version.
Reason
Latest 6.1 kernel includes a bug that causes our network device to experience failed writes in the TAP device.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.