Skip to content

test: call wait_for_up in Microvm.start() #4798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 13, 2024
Merged

test: call wait_for_up in Microvm.start() #4798

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb4392a
test: call `wait_for_up` in `Microvm.start()`
roypat Sep 12, 2024
3315328
test: Call `Microvm.wait_for_up` if using config file
roypat Sep 12, 2024
2d80d65
tests: Call `wait_for_up` in `Microvm.restore_from_snapshot`
roypat Sep 12, 2024
1c804cb
chore(test): remove unneeded `wait_for_up` calls
roypat Sep 12, 2024
4af1906
test: remove unneeded assert on `vm.state`
roypat Sep 12, 2024
6612049
Merge branch 'main' into wait-for-up-by-default
roypat Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/framework/microvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,8 @@ def spawn(
# and leave 0.2 delay between them.
if "no-api" not in self.jailer.extra_args:
self._wait_create()
if "config-file" in self.jailer.extra_args and self.iface:
self.wait_for_up()
if self.log_file and log_level in ("Trace", "Debug", "Info"):
self.check_log_message("Running Firecracker")

Expand Down