-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Enable ftrace in guest kernels #4801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4801 +/- ##
=======================================
Coverage 84.32% 84.32%
=======================================
Files 249 249
Lines 27521 27521
=======================================
Hits 23206 23206
Misses 4315 4315
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bf54f10
to
d08d4d1
Compare
Do we also add |
I can used |
oh, neat! |
This will allows us to debug issues with a guest kernel more easily. Signed-off-by: Egor Lazarchuk <[email protected]>
Disable CONFIG_ARM64_ERRATUM_3194386 option in the guest kernels for aarch64. It is enabled by default and makes `ssbs` feature to not be user space visible. This breaks out integration tests. This option is only indented for `Cortex-X4` and `Neoverse-V3` cpus which we are not using, so disabling it is safe. Signed-off-by: Egor Lazarchuk <[email protected]>
We need to add net interface so the `vm.start()` will wait for a vm to boot. Otherwise the `time.sleep(0.3)` is not enough for a vm to boot and connect to the vhost-user-backend. Signed-off-by: Egor Lazarchuk <[email protected]>
83c7317
to
728080b
Compare
Because now we have ftrace enabled in guest kernels, the boot time increases slightly and no longer satisfies 150000 us time. Signed-off-by: Egor Lazarchuk <[email protected]>
Changes
Enabled
ftrace
feature in guest kernels. This will help us to debug problems in the future.Additionally we need to disable
CONFIG_ARM64_ERRATUM_3194386
in aarch64 guest configs as this option hidesssbs
feature from the guest user space and this breaks our integration test that verifies these features. The option itself was added in recent kernel versions and is intended forCortex-X4
andNeoverse-V3
cpus, and we are not using those. Link: https://lore.kernel.org/stable/[email protected]/Reason
Improve future debug-ability.
Examples:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.