Tiny Fixups #4805
Merged
Tiny Fixups #4805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were needed when the we still had a `wait` step (to overwrite the `wait` step and instead start immediately), however since firecracker-microvm#4803 we do not have a `wait` step anymore (instead everything that used to be after the wait step now explicitly depends on the compilation steps). Thus, having the `depends_on: null` entries for kani and style steps is no longer needed (it also does not harm, but it looks ugly in buildkite's canvas view). Signed-off-by: Patrick Roy <[email protected]>
recieved -> received Signed-off-by: Patrick Roy <[email protected]>
To indicate that we're really waiting until sshd is up and accepting connections, as a proxy for the actual boot process. Suggested during code review in firecracker-microvm#4798. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4805 +/- ##
=======================================
Coverage 84.31% 84.32%
=======================================
Files 249 249
Lines 27521 27521
=======================================
+ Hits 23205 23206 +1
+ Misses 4316 4315 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Sep 16, 2024
roypat
added
the
Status: Awaiting review
kalyazin
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
accumulates various nits from PR reviews that I was gonna "do the next time I touch the code"
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.