test: style: fix black ignoring integration_test/build directory
#4806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `black` is passed multiple directories, it will try to look for `pyproject.toml` in the common ancestor of those paths. In our cases, since we pass it `tests`, `.buildkite` and `tools`, that would be the repository root. However, our pyproject.toml sits in `tests`, and thus the `exclude` rule it defines is ignored (and it is this `exclude` rules that overwrites the default behavior of excluding directories called `build`). Fix this by explicitly passing in a `--config` argument. Since `isort` does not support this argument, pass it in a quite ugly via by adding it to the pytest parameters. Fixes: 4f55e49 Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4806 +/- ##
=======================================
Coverage 84.34% 84.35%
=======================================
Files 249 249
Lines 27504 27504
=======================================
+ Hits 23199 23200 +1
+ Misses 4305 4304 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
approved these changes
Sep 16, 2024
kalyazin
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
blackis passed multiple directories, it will try to look forpyproject.tomlin the common ancestor of those paths. In our cases, since we pass ittests,.buildkiteandtools, that would be the repository root. However, our pyproject.toml sits intests, and thus theexcluderule it defines is ignored (and it is thisexcluderules that overwrites the default behavior of excluding directories calledbuild).Fix this by explicitly passing in a
--configargument. Sinceisortdoes not support this argument, pass it in a quite ugly via by adding it to the pytest parameters.Fixes: 4f55e49
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.