buildkite: fix CPU template pipeline issues #4808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
the
Status: Awaiting author
pb8o
added
Priority: High
pb8o
force-pushed
the
fix-cpu-pipeline
branch
from
13977c0 to
cee778c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4808 +/- ##
=======================================
Coverage 84.34% 84.35%
=======================================
Files 249 249
Lines 27504 27504
=======================================
+ Hits 23199 23200 +1
+ Misses 4305 4304 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
fix-cpu-pipeline
branch
2 times, most recently
from
187b7ca to
8f13ad2
Compare
pb8o
changed the title
pb8o
changed the title
pb8o
force-pushed
the
fix-cpu-pipeline
branch
2 times, most recently
from
7bf3443 to
b9c4484
Compare
zulinx86
reviewed
Sep 17, 2024
pb8o
force-pushed
the
fix-cpu-pipeline
branch
2 times, most recently
from
ccd7817 to
0a8423b
Compare
19e9051 assumed the `agents` is a dict, which was true in all cases except in one pipeline. Fixes: 19e9051 Signed-off-by: Pablo Barbáchano <[email protected]>
If we have more than one build step in a pipeline, Buildkite complains
that they are not unique.
fatal: Failed to upload and process pipeline: Pipeline upload
rejected: The key "build_x86_64" has already been used by another
step in this build
We had a similar issue with shared build tarballs, so just reuse the
tarball name as key.
Fixes: 19e9051
Signed-off-by: Pablo Barbáchano <[email protected]>
pb8o
force-pushed
the
fix-cpu-pipeline
branch
from
0a8423b to
84b2c8d
Compare
zulinx86
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
19e9051 assumed the
agentsis a dict, which was true in all cases except in one pipeline.Fixes: 19e9051
Changes
...
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.