-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(vsock): save state after sending a notification #4812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ShadowCurse
merged 1 commit into
firecracker-microvm:main
from
ShadowCurse:vsock_fix_v2
Sep 18, 2024
Merged
fix(vsock): save state after sending a notification #4812
ShadowCurse
merged 1 commit into
firecracker-microvm:main
from
ShadowCurse:vsock_fix_v2
Sep 18, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4812 +/- ##
=======================================
Coverage ? 84.32%
=======================================
Files ? 249
Lines ? 27512
Branches ? 0
=======================================
Hits ? 23200
Misses ? 4312
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8626243
to
7d4fe76
Compare
pb8o
previously approved these changes
Sep 18, 2024
zulinx86
reviewed
Sep 18, 2024
This is a fix for a fix introduced in firecracker-microvm#4796 The issue was in vsock device hanging after snapshot restoration due to the guest not being notified about the termination packet. But there was bug in the fix, maily we saved the vsock state before the notification was sent, thus discarding all modifications made to sent the notification. The reason original fix worked, is because we were only testing with 1 iteration of snap/restore. This way even though we lost synchronization with the guest in the event queue state, it worked fine once. But doing more iterations causes vsock to hang as before. This commit fixes the issue by storing vsock state after the notification is sent and modifies the vsock test to run multiple iterations of snap/restore. Signed-off-by: Egor Lazarchuk <[email protected]>
7d4fe76
to
9a3ec00
Compare
zulinx86
approved these changes
Sep 18, 2024
pb8o
approved these changes
Sep 18, 2024
5 tasks
CompuIves
added a commit
to codesandbox/firecracker
that referenced
this pull request
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Fix
Indicates a fix to existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a fix for a fix introduced in #4796
The issue was in vsock device hanging after snapshot restoration due to the guest not being notified about the termination packet. But there was bug in the fix: we were saving the vsock state before the notification was sent, thus discarding all modifications made to the queue in order to sent the notification.
The reason original fix worked, is because we were only testing with 1 iteration of snap/restore. This way even though we lose synchronization with the guest in the event queue state, it worked fine once. But doing more iterations causes vsock to hang as before.
This PR fixes the issue by saving the vsock state after the notification is sent and modifies the vsock test to run multiple iterations of snap/restore.
Reason
Fixes: #4811
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.