Skip to content

Conversation

abitrolly
Copy link
Contributor

Changes

Add quotes to prevent escaping and makes the code shellcheck-compliant.

Reason

wezterm escapes unquoted strings on paste, so it becomes wget https://s3.amazonaws.com/spec.ccfc.min/$\{latest\}. Adding quotes fixes that.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Also makes the code `shellcheck`-compliant.

Signed-off-by: Anatoli Babenia <[email protected]>
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 23, 2024
@pb8o pb8o merged commit 7dfca57 into firecracker-microvm:main Sep 23, 2024
5 of 6 checks passed
@abitrolly abitrolly deleted the patch-1 branch September 23, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants