Skip to content

chore: Pin m6i/5.10 AMI to last known good one #4821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: Pin m6i/5.10 AMI to last known good one #4821

merged 1 commit into from
Sep 26, 2024

Conversation

zulinx86
Copy link
Contributor

Reason / Changes

We're observing performance instability on m6i/5.10 which is causing A/B performance test failures. To suppress false positives, pin AMI to the last known good one only for m6i/5.10.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this
    PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet
    contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@zulinx86
chore: Pin m6i/5.10 AMI to last known good one
ebe0a36 
We're observing performance instability on m6i/5.10 which is causing A/B
performance test failures. To suppress false positives, pin AMI to the
last known good one only for m6i/5.10.

Signed-off-by: Takahiro Itazuri <[email protected]>
@zulinx86
Copy link
Contributor Author

It overwrites the target agent like this:

$ python3 .buildkite/pipeline_perf.py --platforms al2-linux_5.10 --instances m6i.metal
{
    "steps": [
        {
            "group": "🏗️ Build",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "./tools/devtool -y build --release",
                        "du -sh build/*",
                        "tar czf build_$(uname -m)_12cA3fCa.tar.gz build",
                        "buildkite-agent artifact upload build_$(uname -m)_12cA3fCa.tar.gz"
                    ],
                    "key": "build_x86_64_12cA3fCa",
                    "label": "🏗 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                },
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m7g.metal",
                        "kv": "linux_5.10",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "./tools/devtool -y build --release",
                        "du -sh build/*",
                        "tar czf build_$(uname -m)_12cA3fCa.tar.gz build",
                        "buildkite-agent artifact upload build_$(uname -m)_12cA3fCa.tar.gz"
                    ],
                    "key": "build_aarch64_12cA3fCa",
                    "label": "🏗 m7g.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "💿 Virtio Block Performance",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_block_ab.py::test_block_performance"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "💿 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "💿 vhost-user Block Performance",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_block_ab.py::test_block_vhost_user_performance"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "💿 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "📠 Network Latency",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_network_ab.py::test_network_latency"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "📠 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "📠 Network TCP Throughput",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_network_ab.py::test_network_tcp_throughput"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "📠 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "📸 Snapshot Latency",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-12 -m 0 --performance --  -m '' integration_tests/performance/test_snapshot_ab.py"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "📸 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "🧦 Vsock Throughput",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_vsock_ab.py"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "🧦 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        },
        {
            "group": "💾 Memory Overhead and 👢 Boottime",
            "steps": [
                {
                    "agents": {
                        "ag": 1,
                        "instance": "m6i.metal",
                        "kv": "linux_5.10-pinned",
                        "os": "al2"
                    },
                    "artifact_paths": [
                        "./test_results/**/*"
                    ],
                    "command": [
                        "buildkite-agent artifact download \"build_$(uname -m)_12cA3fCa.tar.gz\" .",
                        "tar xzf build_$(uname -m)_12cA3fCa.tar.gz",
                        "./tools/devtool -y test --no-build -c 1-10 -m 0 --performance --  -m '' integration_tests/performance/test_memory_overhead.py integration_tests/performance/test_boottime.py::test_boottime"
                    ],
                    "depends_on": "build_x86_64_12cA3fCa",
                    "label": "💾 m6i.metal al2 linux_5.10",
                    "priority": 2,
                    "retry": {
                        "automatic": [
                            {
                                "exit_status": -1,
                                "limit": 1
                            }
                        ]
                    }
                }
            ]
        }
    ]
}

@zulinx86 zulinx86 added Status: Awaiting author Indicates that an issue or pull request requires author action Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Sep 26, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.36%. Comparing base (7803c42) to head (ebe0a36).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4821   +/-   ##
=======================================
  Coverage   84.36%   84.36%           
=======================================
  Files         249      249           
  Lines       27501    27501           
=======================================
  Hits        23202    23202           
  Misses       4299     4299
Flag Coverage Δ
5.10-c5n.metal 84.60% <ø> (ø)
5.10-m5n.metal 84.58% <ø> (ø)
5.10-m6a.metal 83.88% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 80.93% <ø> (ø)
5.10-m6i.metal 84.58% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.93% <ø> (ø)
6.1-c5n.metal 84.59% <ø> (-0.01%) ⬇️
6.1-m5n.metal 84.58% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.87% <ø> (ø)
6.1-m6g.metal 80.93% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 84.58% <ø> (ø)
6.1-m7g.metal 80.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat merged commit f0dd238 into firecracker-microvm:main Sep 26, 2024
8 of 9 checks passed
@zulinx86 zulinx86 deleted the pin_m6i-5.10 branch December 16, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pb8o pb8o pb8o approved these changes

+1 more reviewer

@roypat roypat roypat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zulinx86 @pb8o @roypat