Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Oct 2, 2024

Changes

Update maintainer and codeowner lists.

Reason

To keep it up to date.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this
    PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Update maintainer and codeowner lists.

Signed-off-by: Nikita Kalyazin <[email protected]>
@kalyazin kalyazin requested review from pb8o and xmarcalx as code owners October 2, 2024 10:14
@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (a9e5f13) to head (985adfc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4827   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files         249      249           
  Lines       27505    27505           
=======================================
  Hits        23202    23202           
  Misses       4303     4303           
Flag Coverage Δ
5.10-c5n.metal 84.59% <ø> (ø)
5.10-m5n.metal 84.57% <ø> (-0.01%) ⬇️
5.10-m6a.metal 83.87% <ø> (ø)
5.10-m6g.metal 80.92% <ø> (ø)
5.10-m6i.metal 84.57% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.92% <ø> (ø)
6.1-c5n.metal 84.59% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 84.57% <ø> (ø)
6.1-m6a.metal 83.86% <ø> (ø)
6.1-m6g.metal 80.92% <ø> (ø)
6.1-m6i.metal 84.56% <ø> (-0.02%) ⬇️
6.1-m7g.metal 80.92% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalyazin kalyazin self-assigned this Oct 2, 2024
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 2, 2024
zulinx86
zulinx86 previously approved these changes Oct 2, 2024
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a minor nit as pointed out already.

Sort maintainer list.

Signed-off-by: Nikita Kalyazin <[email protected]>
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the changes Nikita!

@kalyazin kalyazin merged commit fe3ba28 into firecracker-microvm:main Oct 2, 2024
6 of 7 checks passed
@kalyazin kalyazin deleted the codeowners branch October 2, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants