Skip to content

Conversation

@kalyazin
Copy link
Contributor

@kalyazin kalyazin commented Oct 2, 2024

Changes

Update version number / CHANGELOG / CREDITS

Reason

Release v1.9.1

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • [ ] All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (71e478d) to head (3cace4b).
Report is 3 commits behind head on firecracker-v1.9.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           firecracker-v1.9    #4831      +/-   ##
====================================================
+ Coverage             84.33%   84.35%   +0.01%     
====================================================
  Files                   249      249              
  Lines                 27465    27447      -18     
====================================================
- Hits                  23162    23152      -10     
+ Misses                 4303     4295       -8     
Flag Coverage Δ
5.10-c5n.metal 84.57% <ø> (+0.01%) ⬆️
5.10-m5n.metal 84.55% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 83.84% <ø> (+0.01%) ⬆️
5.10-m6g.metal 80.91% <ø> (+0.01%) ⬆️
5.10-m6i.metal 84.55% <ø> (+<0.01%) ⬆️
5.10-m7g.metal 80.91% <ø> (+0.01%) ⬆️
6.1-c5n.metal 84.56% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 84.55% <ø> (+0.01%) ⬆️
6.1-m6a.metal 83.84% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 80.91% <ø> (+0.01%) ⬆️
6.1-m6i.metal 84.55% <ø> (+<0.01%) ⬆️
6.1-m7g.metal 80.91% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kalyazin kalyazin force-pushed the 1.9 branch 2 times, most recently from ce1623a to 62cb52e Compare October 2, 2024 16:13
@kalyazin kalyazin marked this pull request as ready for review October 2, 2024 16:40
@kalyazin kalyazin requested review from pb8o and xmarcalx as code owners October 2, 2024 16:40
@kalyazin kalyazin self-assigned this Oct 2, 2024
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 2, 2024
pb8o
pb8o previously approved these changes Oct 2, 2024
ShadowCurse and others added 2 commits October 2, 2024 16:48
Disable CONFIG_ARM64_ERRATUM_3194386 option in the guest
kernels for aarch64. It is enabled by default
and makes `ssbs` feature to not be user space visible. This breaks
out integration tests.
This option is only indented for `Cortex-X4` and
`Neoverse-V3` cpus which we are not using, so disabling it
is safe.

Signed-off-by: Egor Lazarchuk <[email protected]>
Add entries to `.mailmap` to make re-generating CREDITS.md easier.

- Deduplicate some entries.
- Correct some existing addresses of maintainers.

Signed-off-by: Pablo Barbáchano <[email protected]>
Update version number / CHANGELOG / CREDITS

Signed-off-by: Nikita Kalyazin <[email protected]>
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the changes

@kalyazin kalyazin merged commit 3370eaf into firecracker-microvm:firecracker-v1.9 Oct 3, 2024
6 of 7 checks passed
@kalyazin kalyazin deleted the 1.9 branch October 3, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants