Skip to content

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Oct 8, 2024

Kani supports verification on ARM since version 0.37.0 1, so enable it in our CI.

Merging this required rebuilding the docker container, so this commit should get picked up the next time we do that.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Kani supports verification on ARM since version 0.37.0 [1], so enable it
in our CI.

[1]: https://github.com/model-checking/kani/blob/main/CHANGELOG.md#0370

Signed-off-by: Patrick Roy <[email protected]>
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.35%. Comparing base (9b136c0) to head (b94a349).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4843   +/-   ##
=======================================
  Coverage   84.35%   84.35%           
=======================================
  Files         249      249           
  Lines       27505    27505           
=======================================
  Hits        23202    23202           
  Misses       4303     4303           
Flag Coverage Δ
5.10-c5n.metal 84.59% <ø> (ø)
5.10-m5n.metal 84.57% <ø> (ø)
5.10-m6a.metal 83.86% <ø> (ø)
5.10-m6g.metal 80.92% <ø> (ø)
5.10-m6i.metal 84.56% <ø> (ø)
5.10-m7g.metal 80.92% <ø> (ø)
6.1-c5n.metal 84.59% <ø> (ø)
6.1-m5n.metal 84.57% <ø> (ø)
6.1-m6a.metal 83.86% <ø> (-0.01%) ⬇️
6.1-m6g.metal 80.92% <ø> (ø)
6.1-m6i.metal 84.56% <ø> (ø)
6.1-m7g.metal 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat
Copy link
Contributor Author

roypat commented Oct 8, 2024

@pb8o folded this into #4784. Thanks!

@roypat roypat closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant