Skip to content

fix: ignore vsock related failure metrics #4851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix: ignore vsock related failure metrics #4851

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9364472
fix: ignore vsock related failure metrics
roypat Oct 15, 2024
0f431d8
Merge branch 'main' into vsock-metric-ignore
roypat Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tests/host_tools/fcmetrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,11 +466,19 @@ def flatten_dict(node, prefix: str):

metrics.flush()

ignored_failure_metrics = [
# We trigger these spuriously in vsock tests due to iperf-vsock not implementing connection shutdown
# See also https://github.com/stefano-garzarella/iperf-vsock/issues/4
"fc_metrics.vsock.rx_read_fails",
"fc_metrics.vsock.tx_write_fails",
]

failure_metrics = {
key: value
for key, value in flattened_metrics.items()
if "err" in key or "fail" in key or "panic" in key or "num_faults" in key
if value
if key not in ignored_failure_metrics
}
assert not failure_metrics, json.dumps(failure_metrics, indent=1)

Expand Down
Loading