Skip to content

test: move "doing A/B-Test" print statement below ignore-check #4853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2024
Merged

test: move "doing A/B-Test" print statement below ignore-check #4853

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fce53e5
test: move "doing A/B-Test" print statement below ignore-check
roypat Oct 15, 2024
ea98c93
Merge branch 'main' into more-ab-print
roypat Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tools/ab_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ def analyze_data(
), "A and B run produced incomparable data. This is a bug in the test!"

for metric, (values_a, unit) in metrics_a.items():
print(
f"Doing A/B-test for dimensions {dimension_set} and property {metric}"
)
result = check_regression(
values_a, metrics_b[metric][0], n_resamples=n_resamples
)
Expand Down Expand Up @@ -269,6 +266,8 @@ def analyze_data(
if is_ignored(dict(dimension_set)):
continue

print(f"Doing A/B-test for dimensions {dimension_set} and property {metric}")

values_a = processed_emf_a[dimension_set][metric][0]
baseline_mean = statistics.mean(values_a)

Expand Down
Loading