Skip to content

Conversation

@Manciukic
Copy link
Contributor

Changes

Update slack invite to the public workspace:
https://join.slack.com/t/firecracker-microvm/shared_invite/zt-2tc0mfxpc-tU~HYAYSzLDl5XGGJU3YIg

Reason

The old link expired: #4860

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

The previous link expired, updating it.

Closes: firecracker-microvm#4860
Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic force-pushed the pull_requests/fix-slack-link branch from 994ea25 to c168b97 Compare October 22, 2024 15:22
@Manciukic Manciukic marked this pull request as ready for review October 22, 2024 15:23
@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Oct 22, 2024
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@pb8o pb8o merged commit 8c8ee32 into firecracker-microvm:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants