Skip to content

#4768: Don't check KVM in tools/devtool checkstyle #4868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

#4768: Don't check KVM in tools/devtool checkstyle #4868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tools/devtool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,6 +661,7 @@ unapply_performance_tweaks() {
cmd_test() {
do_ab_test=0
do_build=1
do_kvm_check=1
# Parse any command line args.
while [ $# -gt 0 ]; do
case "$1" in
Expand All @@ -682,6 +683,9 @@ cmd_test() {
"--no-build")
do_build=0
;;
"--no-kvm-check")
do_kvm_check=0
;;
"--") { shift; break; } ;;
*)
die "Unknown argument: $1. Please use --help for help."
Expand All @@ -691,7 +695,7 @@ cmd_test() {
done

# Check prerequisites.
ensure_kvm
[ $do_kvm_check != 0 ] && ensure_kvm
ensure_devctr
ensure_build_dir
ensure_ci_artifacts
Expand Down Expand Up @@ -907,7 +911,7 @@ cmd_mkdocs() {
}

cmd_checkstyle() {
cmd_test --no-build -- integration_tests/style -n 4 --dist worksteal
cmd_test --no-build --no-kvm-check -- integration_tests/style -n 4 --dist worksteal
}

# Check if able to run firecracker.
Expand Down
Loading