Add CHANGELOG entry on support of ARM systems with big caches #4871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firecracker-microvm#4869 changed the type that holds the number of sets of a CPU cache from `u16` to `u32`. This allows us to support ARM systems with CPU caches with sets more than `u16::MAX`. Add a CHANGELOG entry for this change Signed-off-by: Babis Chalios <[email protected]>
bchalios
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
bchalios
added
Status: Awaiting review
kalyazin
approved these changes
Oct 24, 2024
pb8o
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a CHANGELOG entry for changes in #4869
Reason
#4869 changed the type that holds the number of sets of a CPU cache from
u16tou32. This allows us to support ARM systems with CPU caches with sets more thanu16::MAX.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.