Skip to content

Add Ubuntu 24.10 to popular containers #4882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Add Ubuntu 24.10 to popular containers #4882

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f413a6
test: add Ubuntu 24.10 to popular test
pb8o Oct 29, 2024
a7ae361
test: drop support for unsupported versions
pb8o Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions tests/framework/artifacts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from pathlib import Path
from typing import Iterator

import packaging.version
import pytest

from framework.defs import ARTIFACT_DIR
Expand Down Expand Up @@ -98,9 +97,6 @@ def snapshot_version_tuple(self):
# independent of Firecracker versions. For these Firecracker versions, use
# the --snapshot-version Firecracker flag, to figure out which snapshot version
# it supports.
# TODO: remove this check once all version up to (and including) 1.6.0 go out of support.
if packaging.version.parse(self.version) < packaging.version.parse("1.7.0"):
return self.version_tuple[:2] + (0,)

return (
check_output([self.path, "--snapshot-version"])
Expand Down
9 changes: 0 additions & 9 deletions tests/integration_tests/functional/test_cmd_line_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import subprocess
from pathlib import Path

import packaging.version
import pytest

from framework.utils import check_output
Expand All @@ -22,14 +21,6 @@ def test_describe_snapshot_all_versions(
snapshot state file.
"""

# TODO: remove this check once all versions prior to 1.6.0 go out of support.
if packaging.version.parse(firecracker_release.version) < packaging.version.parse(
"1.7.0"
):
pytest.skip(
"We can't parse snapshot files created from Firecracker with version < 1.7.0."
)

target_version = firecracker_release.snapshot_version
vm = microvm_factory.build(
guest_kernel,
Expand Down
2 changes: 1 addition & 1 deletion tools/test-popular-containers/build_rootfs.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,6 @@ EOF

make_rootfs alpine:latest
make_rootfs ubuntu:22.04
make_rootfs ubuntu:23.10
make_rootfs ubuntu:24.04
make_rootfs ubuntu:24.10
# make_rootfs ubuntu:latest
Loading