Skip to content

net: revert virtio-net queue size to 256 #4895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2024
+1 −5
Merged

net: revert virtio-net queue size to 256 #4895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dab3e6b
net: revert virtio-net queue size to 256
bchalios Nov 6, 2024
fd149d0
Merge branch 'main' into revert_net_queue_size_change
bchalios Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ and this project adheres to

### Changed

- [#4875](https://github.com/firecracker-microvm/firecracker/pull/4875):
Increase default queue size for the `virtio-net` device from 256 to 512. This
decreases wait time between guest and vmm threads for network packets
processing and allows for more throughput.
- [#4844](https://github.com/firecracker-microvm/firecracker/pull/4844): Upgrade
`virtio-net` device to use `readv` syscall to avoid unnecessary memory copies
on RX path, increasing the RX performance.
Expand Down
2 changes: 1 addition & 1 deletion src/vmm/src/devices/virtio/net/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
use std::io;

/// Maximum size of the queue for network device.
pub const NET_QUEUE_MAX_SIZE: u16 = 512;
pub const NET_QUEUE_MAX_SIZE: u16 = 256;
/// Maximum size of the frame buffers handled by this device.
pub const MAX_BUFFER_SIZE: usize = 65562;
/// The number of queues of the network device.
Expand Down
Loading