Skip to content

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Nov 13, 2024

Add the SVE CPU template as a valid template in 5.10 since it works.

Changes

Test ARM CPU templates in host Linux 5.10

Reason

While not all ARM CPU templates work in 5.10, some simple ones like enabling SVE work.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting author Indicates that an issue or pull request requires author action python Pull requests that update Python code labels Nov 13, 2024
@pb8o pb8o self-assigned this Nov 13, 2024
@pb8o pb8o marked this pull request as ready for review November 13, 2024 09:58
Add the SVE CPU template as a valid template in 5.10 since it works.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o force-pushed the test-arm-cpu-5-10 branch from 6faf258 to f7cd627 Compare November 13, 2024 10:06
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.10%. Comparing base (5a23130) to head (f7cd627).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4911   +/-   ##
=======================================
  Coverage   84.10%   84.10%           
=======================================
  Files         251      251           
  Lines       28080    28080           
=======================================
  Hits        23616    23616           
  Misses       4464     4464           
Flag Coverage Δ
5.10-c5n.metal 84.67% <ø> (ø)
5.10-m5n.metal 84.65% <ø> (ø)
5.10-m6a.metal 83.97% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 80.78% <ø> (ø)
5.10-m6i.metal 84.65% <ø> (-0.01%) ⬇️
5.10-m7g.metal 80.78% <ø> (ø)
6.1-c5n.metal 84.67% <ø> (ø)
6.1-m5n.metal 84.65% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.96% <ø> (ø)
6.1-m6g.metal 80.78% <ø> (ø)
6.1-m6i.metal 84.65% <ø> (ø)
6.1-m7g.metal 80.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Nov 13, 2024
Copy link
Contributor

@Manciukic Manciukic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no change in the guest set of features between host kernel 5.10 and 6.1? nice!

@pb8o pb8o merged commit 1de16b3 into firecracker-microvm:main Nov 13, 2024
8 checks passed
@pb8o pb8o deleted the test-arm-cpu-5-10 branch November 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants