Skip to content

CI: report all microcode packages and pass arbitrary parameters to steps #4965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

CI: report all microcode packages and pass arbitrary parameters to steps #4965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69d86e0
ci: allow passing a dict/list as a step parameter
pb8o Dec 17, 2024
b383afc
ci: report all microcode packages during a test run
pb8o Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .buildkite/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"""

import argparse
import ast
import json
import os
import random
Expand Down Expand Up @@ -138,7 +139,7 @@ def __call__(self, parser, namespace, value, option_string=None):
res = getattr(namespace, self.dest, {})
key_str, val = value.split("=", maxsplit=1)
keys = key_str.split("/")
update = {keys[-1]: val}
update = {keys[-1]: ast.literal_eval(val)}
for key in list(reversed(keys))[1:]:
update = {key: update}
res = overlay_dict(res, update)
Expand Down
2 changes: 1 addition & 1 deletion tools/devtool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ cmd_test() {
# If we got to here, we've got all we need to continue.
say "Kernel version: $(uname -r)"
say "$(sed '/^processor.*: 0$/,/^processor.*: 1$/!d; /^processor.*: 1$/d' /proc/cpuinfo)"
say "RPM microcode_ctl version: $(rpm -q microcode_ctl)"
say "RPM firmware versions: $(rpm -q microcode_ctl amd-ucode-firmware linux-firmware)"

env |grep -P "^(AWS_EMF_|BUILDKITE|CODECOV_)" > env.list
if [[ $performance_tweaks -eq 1 ]]; then
Expand Down
Loading