Skip to content

Conversation

@ShadowCurse
Copy link
Contributor

Changes

Update kani tool-chain.
Unpin cargo-deny because rust tool-chain has been upgraded.
Specify tag for libseccomp to have a fixed version.
Allow seccomp rules integration test to run on aarch64.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Unpin cargo-deny because rust tool-chain has been upgraded.
Specify tag for libseccomp to have a fixed version.

Signed-off-by: Egor Lazarchuk [email protected]

Unpin cargo-deny because rust tool-chain has been upgraded.
Specify tag for libseccomp to have a fixed version.

Signed-off-by: Egor Lazarchuk <[email protected]>
@codecov
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (f610cae) to head (ab4939a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4982   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         248      248           
  Lines       27839    27839           
=======================================
  Hits        23371    23371           
  Misses       4468     4468           
Flag Coverage Δ
5.10-c5n.metal 84.53% <ø> (ø)
5.10-m5n.metal 84.51% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 83.80% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 80.63% <ø> (ø)
5.10-m6i.metal 84.51% <ø> (+0.01%) ⬆️
5.10-m7g.metal 80.63% <ø> (ø)
6.1-c5n.metal 84.53% <ø> (ø)
6.1-m5n.metal 84.51% <ø> (-0.01%) ⬇️
6.1-m6a.metal 83.79% <ø> (ø)
6.1-m6g.metal 80.63% <ø> (ø)
6.1-m6i.metal 84.50% <ø> (-0.01%) ⬇️
6.1-m7g.metal 80.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Remove skip for test_redundant_seccomp_rules for aarch64.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse self-assigned this Jan 8, 2025
@ShadowCurse ShadowCurse added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jan 8, 2025
@ShadowCurse ShadowCurse requested review from pb8o and roypat January 8, 2025 11:44
@ShadowCurse ShadowCurse merged commit 5925eb2 into firecracker-microvm:main Jan 8, 2025
7 of 8 checks passed
@ShadowCurse ShadowCurse deleted the docker_update branch January 8, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants