Skip to content

Conversation

@pb8o
Copy link
Contributor

@pb8o pb8o commented Jan 20, 2025

Changes

We have sometimes seen that this test can fail. In theory it could
happen that udev has not created the /dev/ptp0 file before we run the
ssh command.

So let's wait in udev for the device to appear up to 5 seconds.

Reason

Prevents (rare) test failures.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Type: Fix Indicates a fix to existing code python Pull requests that update Python code labels Jan 20, 2025
roypat
roypat previously approved these changes Jan 20, 2025
We have sometimes seen that this test can fail. In theory it could
happen that udev has not created the /dev/ptp0 file before we run the
ssh command.

So let's wait in udev for the device to appear up to 5 seconds.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o added the Status: Awaiting author Indicates that an issue or pull request requires author action label Jan 20, 2025
@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (2b3ec74) to head (0f7fa6f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5002      +/-   ##
==========================================
+ Coverage   82.92%   83.10%   +0.18%     
==========================================
  Files         243      245       +2     
  Lines       26514    26723     +209     
==========================================
+ Hits        21987    22209     +222     
+ Misses       4527     4514      -13     
Flag Coverage Δ
5.10-c5n.metal 83.57% <ø> (ø)
5.10-m5n.metal 83.55% <ø> (?)
5.10-m6a.metal 82.76% <ø> (?)
5.10-m6g.metal 79.57% <ø> (ø)
5.10-m6i.metal 83.54% <ø> (?)
5.10-m7g.metal 79.57% <ø> (ø)
6.1-c5n.metal 83.57% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 83.55% <ø> (?)
6.1-m6a.metal 82.76% <ø> (?)
6.1-m6g.metal 79.56% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.54% <ø> (?)
6.1-m7g.metal 79.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Jan 20, 2025
@pb8o pb8o requested a review from roypat January 20, 2025 13:55
@pb8o pb8o self-assigned this Jan 20, 2025
@pb8o pb8o merged commit 994198b into firecracker-microvm:main Jan 20, 2025
8 of 9 checks passed
@pb8o pb8o deleted the test-kvm-ptp branch January 20, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants