fix: Allow jailer to continue with partial CPU cache info #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
With this change, the |
ShadowCurse
reviewed
Mar 5, 2025
Contributor
ShadowCurse
left a comment
ShadowCurse
left a comment
There was a problem hiding this comment.
Hi @gudmundur, thank you for the PR. Even though Firecracker officially does not support nested virtualization usage, it will be nice to have a consistent behavior between Jailer and Firecracker.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5062 +/- ##
==========================================
- Coverage 83.19% 83.18% -0.01%
==========================================
Files 247 247
Lines 26814 26817 +3
==========================================
+ Hits 22308 22309 +1
- Misses 4506 4508 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If CPU caching information is missing, this change allows the jailer to still continue, and fall through to the validation logic in firecracker. Signed-off-by: Gudmundur Bjarni Olafsson <[email protected]>
gudmundur
force-pushed
the
fix-jailer-partial-cpu-cache-info-crash
branch
from
f1705c7 to
426b027
Compare
roypat
approved these changes
Mar 7, 2025
Manciukic
approved these changes
Mar 7, 2025
roypat
added
the
Status: Awaiting review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Allows the
jailerto continue when files in/sys/devices/system/cpu/cpuX/cache/indexY/are missing.Reason
Nested virtualization support was added on macOS Sequoia for Apple M3/M4 chips. When using
vzwith Lima a few of the CPU cache information files are missing, namelysize,coherency_line_size, andnumber_of_sets.firecrackeritself handles if these files are missing, while thejailerdoesn't . This patch passes whatever is present to the copied cache information, and allowsfirecrackerto determine if it is valid or not.By making this change, we are able to simplify our development environments drastically by not requiring either GitHub Codespaces or AWS EC2 metal instances.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.- [ ] If a specific issue led to this PR, this PR closes the issue.- [ ] When making API changes, I have followed theRunbook for Firecracker API changes.
integration tests.
- [ ] I have linked an issue to every newTODO.rust-vmm.