-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Jailer tweaks #5068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jailer tweaks #5068
Conversation
e808757 to
54d3655
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5068 +/- ##
=======================================
Coverage 83.19% 83.19%
=======================================
Files 247 247
Lines 26641 26638 -3
=======================================
- Hits 22163 22162 -1
+ Misses 4478 4476 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roypat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
54d3655 to
6b2472a
Compare
Add a comment why we wrap the actual main inplementation. Signed-off-by: Egor Lazarchuk <[email protected]>
Since Rust 1.77 we can create constants with C strings without runtime conversion. Signed-off-by: Egor Lazarchuk <[email protected]>
As a follow up of the previous commit, replace string which should be C string with CStr. Signed-off-by: Egor Lazarchuk <[email protected]>
6b2472a to
5544bd1
Compare
Changes
CStrconstants for paths avoiding runtime conversion.Reason
Since Rust 1.77
CStrcan be created withcprefix to string. Use this to simplify the code and remove runtime conversions.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.