chore(aarch64): increase the max_value for timer reset test #5072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
the
Status: Awaiting review
JackThomson2
previously approved these changes
Mar 10, 2025
ShadowCurse
force-pushed
the
aarch64_vcpu_timeout
branch
from
0d83c46 to
27bc471
Compare
kalyazin
previously approved these changes
Mar 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5072 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 247 247
Lines 26816 26816
=======================================
Hits 22306 22306
Misses 4510 4510
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
aarch64_vcpu_timeout
branch
from
27bc471 to
2704cf4
Compare
The counter value observed in tests sometimes is a bit larger than 1000 cycles. Adjust max_value to accommodate this. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
aarch64_vcpu_timeout
branch
from
2704cf4 to
922bc09
Compare
JackThomson2
approved these changes
Mar 10, 2025
kalyazin
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The counter value observed in tests sometimes is a bit larger than 1000 cycles. Adjust max_value to accommodate this.
Reason
Less intermediate failures.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.