Skip to content

Conversation

Manciukic
Copy link
Contributor

Changes

Backport #5081

Reason

Fix cargo audit

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.19%. Comparing base (4e40479) to head (66390fd).
Report is 1 commits behind head on firecracker-v1.11.

Additional details and impacted files
@@                Coverage Diff                 @@
##           firecracker-v1.11    #5093   +/-   ##
==================================================
  Coverage              83.19%   83.19%           
==================================================
  Files                    247      247           
  Lines                  26641    26641           
==================================================
  Hits                   22165    22165           
  Misses                  4476     4476           
Flag Coverage Δ
5.10-c5n.metal 83.67% <ø> (ø)
5.10-m5n.metal 83.66% <ø> (ø)
5.10-m6a.metal 82.86% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.67% <ø> (ø)
5.10-m6i.metal 83.65% <ø> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.86% <ø> (ø)
5.10-m7g.metal 79.67% <ø> (ø)
6.1-c5n.metal 83.67% <ø> (ø)
6.1-m5n.metal 83.65% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.86% <ø> (ø)
6.1-m6g.metal 79.66% <ø> (-0.01%) ⬇️
6.1-m6i.metal 83.65% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.86% <ø> (ø)
6.1-m7g.metal 79.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@bchalios bchalios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you run cherry-pick with the -x flag, so that it adds the message about cherry-picking? Keep in mind that this will probably add the line about cherry-picking between Signed-off-by lines and git lints will complain. You'll need to move it around

While gdbstub moves away from paste as a dependency we will ignore this
warning.

(cherry picked from commit e7f6051)

Signed-off-by: Jack Thomson <[email protected]>
Signed-off-by: Riccardo Mancini <[email protected]>
@Manciukic Manciukic force-pushed the v1.11/cargo-audit-fix branch from ad7351e to 66390fd Compare March 18, 2025 15:24
@Manciukic
Copy link
Contributor Author

Could you run cherry-pick with the -x flag, so that it adds the message about cherry-picking? Keep in mind that this will probably add the line about cherry-picking between Signed-off-by lines and git lints will complain. You'll need to move it around

Added the "cherry picked from" line

@Manciukic Manciukic added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 18, 2025
@ShadowCurse ShadowCurse enabled auto-merge (rebase) March 18, 2025 15:51
@ShadowCurse ShadowCurse merged commit 762f659 into firecracker-microvm:firecracker-v1.11 Mar 18, 2025
7 of 8 checks passed
@Manciukic Manciukic deleted the v1.11/cargo-audit-fix branch March 18, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants