Snap restore test with templates #5095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5095 +/- ##
=======================================
Coverage 83.14% 83.14%
=======================================
Files 248 248
Lines 26925 26925
=======================================
Hits 22388 22388
Misses 4537 4537
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
2 times, most recently
from
89c112b to
d9eee62
Compare
ShadowCurse
added
Status: Awaiting review
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
from
d9eee62 to
bce8d0b
Compare
roypat
approved these changes
Mar 19, 2025
bchalios
approved these changes
Mar 19, 2025
JackThomson2
approved these changes
Mar 19, 2025
Enable SVE and PAC custom template for G4. Signed-off-by: Egor Lazarchuk <[email protected]>
Add template parameter to the snapshot cycle test to increase the test coverage. Signed-off-by: Egor Lazarchuk <[email protected]>
Rename test to `test_cycled_snapshot_restore` and add a better comment to better explain what the test does. Also reduce number of cycles to 3 to speed test a bit. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
snap_restore_with_templates
branch
from
bce8d0b to
217900d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update
test_5_snapshotstest to test with cpu_templates as well. Also enable sve + pac template for G4.Reason
We did not have snapshot tests with cpu templates.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.