Skip to content

Conversation

ShadowCurse
Copy link
Contributor

Changes

Add a case for G4 with sve+pac template to the guest cpu feature check test.

Reason

Fixes test for G4 with sve+pac template.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Add a case for G4 with sve+pac template to the guest cpu feature check
test.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse self-assigned this Mar 20, 2025
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code labels Mar 20, 2025
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.14%. Comparing base (c4a9ea9) to head (c7c0243).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5099   +/-   ##
=======================================
  Coverage   83.14%   83.14%           
=======================================
  Files         248      248           
  Lines       26925    26925           
=======================================
  Hits        22388    22388           
  Misses       4537     4537           
Flag Coverage Δ
5.10-c5n.metal 83.53% <ø> (ø)
5.10-m5n.metal 83.52% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.71% <ø> (ø)
5.10-m6g.metal 79.57% <ø> (ø)
5.10-m6i.metal 83.51% <ø> (ø)
5.10-m7a.metal-48xl 82.71% <ø> (?)
5.10-m7g.metal 79.57% <ø> (ø)
6.1-c5n.metal 83.58% <ø> (ø)
6.1-m5n.metal 83.57% <ø> (ø)
6.1-m6a.metal 82.75% <ø> (-0.01%) ⬇️
6.1-m6g.metal 79.57% <ø> (ø)
6.1-m6i.metal 83.55% <ø> (ø)
6.1-m7a.metal-48xl 82.75% <ø> (?)
6.1-m7g.metal 79.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bchalios bchalios merged commit aa73f45 into firecracker-microvm:main Mar 20, 2025
8 of 9 checks passed
@ShadowCurse ShadowCurse deleted the fix_g4_cpu_feat_test branch March 20, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants