doc: clarify kernel configuration usage in our repo #5104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
bchalios
added
Status: Awaiting review
3 tasks
ShadowCurse
reviewed
Mar 21, 2025
Manciukic
reviewed
Mar 21, 2025
bchalios
force-pushed
the
specify_kernel_config_requirements
branch
from
3137642 to
58f71e7
Compare
Manciukic
previously approved these changes
Mar 21, 2025
roypat
reviewed
Mar 21, 2025
We keep in the repo the kernel configurations from which we build the kernel images we use in our CI pipelines. However, we don't mention what kernel sources we use to build these kernel images. Clarify in the documentation that these configurations are meant to be used with kernels provided by Amazon Linux and that we don't guarantee that they can be used to build kernels from upstream Linux. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
specify_kernel_config_requirements
branch
from
58f71e7 to
9ce001b
Compare
roypat
approved these changes
Mar 24, 2025
Manciukic
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Clarify in the documentation that the kernel configurations we keep in our repo are meant to be used with kernels provided by Amazon Linux and that we don't guarantee that they can be used to build kernels from upstream Linux.
Reason
We keep in the repo the kernel configurations from which we build the kernel images we use in our CI pipelines. However, we don't mention what kernel sources we use to build these kernel images.
Fixes #4881
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.