[1.11] backport Kani fixes #5107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases running kani steps is not useful and only results in longer pipeline runs. Add option to disable it if needed. (cherry picked from commit 83119b8) Signed-off-by: Egor Lazarchuk <[email protected]>
Kani tests run very close to the current timeout values. Increase timeout to 1h. (cherry picked from commit ed0d202) Signed-off-by: Egor Lazarchuk <[email protected]>
--enable-unstable and --restrict-vtable got deprecated in kani 0.59.0 in favor of variants based on -Z flags. So use the -Z flags instead (cherry picked from commit 8495af9) Signed-off-by: Patrick Roy <[email protected]>
rebuilding the docker container can upgrade kani, and we'd like to know at the PR stage if that causes issues (such as timeouts). (cherry picked from commit 0fff2c8) Signed-off-by: Patrick Roy <[email protected]>
Instead of copying the buffers byte-by-byte in a loop, just use copy_from_slice, which compiles to a memcpy. While we're at it, drop some unused function definitions. Also remove the special snowflake functions for dealing with i8 slices, and instead just use zerocopy to safely transmute these into u8 slices, on which the normal functions work. (cherry picked from commit 35d6afd) Signed-off-by: Patrick Roy <[email protected]>
with the byte_order modules no longer using loops, this is no longer needed. (cherry picked from commit dd0d932) Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.11 #5107 +/- ##
=====================================================
- Coverage 83.19% 83.19% -0.01%
=====================================================
Files 247 247
Lines 26641 26636 -5
=====================================================
- Hits 22165 22160 -5
Misses 4476 4476
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
added
the
Status: Awaiting review
I just didn't want to resolve the merge conflict by hand. |
ShadowCurse
approved these changes
Mar 24, 2025
ShadowCurse
merged commit b5ee7be
into
firecracker-microvm:firecracker-v1.11
7 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backport #5069 and #5078 .
Reason
Bumping devctr version (75b1a1d) brought Kani timeouts that we observed in main.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
[ ] I have mentioned all user-facing changes inCHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.[ ] When making API changes, I have followed theRunbook for Firecracker API changes.
[ ] I have tested all new and changed functionalities in unit tests and/orintegration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.