Skip to content

Fixes for test_population_latency #5111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 25, 2025
Merged

Fixes for test_population_latency #5111

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0114b0a
test(api): exclude /snapshot/load from duration check
kalyazin Mar 24, 2025
2442ac5
test(devtool): sextuple number of preallocated huge pages
kalyazin Mar 24, 2025
ee68dcc
Merge branch 'main' into snap_fix
roypat Mar 25, 2025
cdb6454
Merge branch 'main' into snap_fix
kalyazin Mar 25, 2025
165431a
Merge branch 'main' into snap_fix
roypat Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/framework/microvm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def _validate_api_response_times(self):
"Got API call duration log entry before request entry"
)

if current_call.url != "/snapshot/create":
if current_call.url not in ["/snapshot/create", "/snapshot/load"]:
exec_time = float(match.group("execution_time")) / 1000.0

assert (
Expand Down
4 changes: 2 additions & 2 deletions tools/devtool
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,9 +743,9 @@ cmd_test() {
# It seems that even if the tests using huge pages run sequentially on ag=1 agents, right-sizing the huge pages
# pool to the total number of huge pages used across all tests results in spurious failures with pool depletion
# anyway (something else on the host seems to be stealing our huge pages, and we cannot "ear mark" them for
# Firecracker processes). Thus, just allocate 8GB of them and call it a day.
# Firecracker processes). Thus, just allocate 48GB of them and call it a day.
say "Setting up huge pages pool"
num_hugetlbfs_pages=4096
num_hugetlbfs_pages=24552

huge_pages_old=$(cat /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages)
huge_pages_new=$(echo $num_hugetlbfs_pages |sudo tee /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages)
Expand Down