Skip to content

Conversation

kalyazin
Copy link
Contributor

Changes

Move instead of copying VM artifacts (like mem snapshot files).

Reason

This is to keep free space in the /srv filesystem.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • [ ] I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • [ ] I have mentioned all user-facing changes in CHANGELOG.md.
  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • [ ] I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

This is to keep free space in the /srv filesystem.

Signed-off-by: Nikita Kalyazin <[email protected]>
@kalyazin kalyazin requested a review from Copilot March 27, 2025 11:57
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the tests to move VM artifact files instead of copying them, ensuring that free space is preserved on the /srv filesystem.

  • Replaces the call to shutil.copy with shutil.move to transfer VM artifacts.
  • Limits file operations to only the backup functionality in test configuration for microvm setup.
Comments suppressed due to low confidence (1)

tests/conftest.py:340

  • Switching from copying to moving files can introduce issues if subsequent code expects the original file at src. Please ensure that no side-effects occur due to the file being moved rather than copied.
shutil.move(src, dst)

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (e94b72b) to head (a97e539).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5119   +/-   ##
=======================================
  Coverage   83.06%   83.06%           
=======================================
  Files         250      250           
  Lines       26876    26876           
=======================================
  Hits        22324    22324           
  Misses       4552     4552           
Flag Coverage Δ
5.10-c5n.metal 83.52% <ø> (ø)
5.10-m5n.metal 83.52% <ø> (ø)
5.10-m6a.metal 82.71% <ø> (-0.01%) ⬇️
5.10-m6g.metal 79.43% <ø> (ø)
5.10-m6i.metal 83.52% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.72% <ø> (?)
5.10-m7g.metal 79.43% <ø> (ø)
6.1-c5n.metal 83.57% <ø> (+<0.01%) ⬆️
6.1-m5n.metal 83.56% <ø> (ø)
6.1-m6a.metal 82.76% <ø> (+<0.01%) ⬆️
6.1-m6g.metal 79.43% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 83.56% <ø> (+<0.01%) ⬆️
6.1-m7a.metal-48xl 82.76% <ø> (?)
6.1-m7g.metal 79.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalyazin kalyazin self-assigned this Mar 27, 2025
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Mar 27, 2025
@kalyazin kalyazin merged commit f6fa622 into firecracker-microvm:main Mar 27, 2025
7 of 8 checks passed
@kalyazin kalyazin deleted the move branch March 27, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants