Skip to content

Secret Hiding: Skip more huge page tests and run build nightly #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2025
Merged

Secret Hiding: Skip more huge page tests and run build nightly #5124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4a948a
test: Skip final huge page tests
JackThomson2 Mar 28, 2025
83038c6
tests(bk): Run the kernel build in our nightly PR
JackThomson2 Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline_pr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
for step in kani_grp["steps"]:
step["label"] = "🔍 Kani"

if any(x.parent.name == "hiding_ci" for x in changed_files):
if not changed_files or (any(x.parent.name == "hiding_ci" for x in changed_files)):
pipeline.build_group_per_arch(
"🕵️ Build Secret Hiding Kernel",
pipeline.devtool_test(
Expand Down
19 changes: 19 additions & 0 deletions tests/integration_tests/performance/test_snapshot_ab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Copyright 2023 Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0
"""Performance benchmark for snapshot restore."""

import re
import signal
import tempfile
Expand Down Expand Up @@ -106,6 +107,15 @@ def test_restore_latency(

We only test a single guest kernel, as the guest kernel does not "participate" in snapshot restore.
"""
if (
test_setup.huge_pages != HugePagesConfig.NONE
and global_props.host_linux_version_tpl > (6, 1)
and global_props.cpu_architecture == "aarch64"
):
pytest.skip(
"huge pages with secret hiding kernels on ARM are currently failing"
)

vm = test_setup.boot_vm(microvm_factory, guest_kernel_linux_5_10, rootfs)

metrics.set_dimensions(
Expand Down Expand Up @@ -218,6 +228,15 @@ def test_population_latency(
mem,
):
"""Collects population latency metrics (e.g. how long it takes UFFD handler to fault in all memory)"""
if (
huge_pages != HugePagesConfig.NONE
and global_props.host_linux_version_tpl > (6, 1)
and global_props.cpu_architecture == "aarch64"
):
pytest.skip(
"huge pages with secret hiding kernels on ARM are currently failing"
)

test_setup = SnapshotRestoreTest(mem=mem, vcpus=vcpus, huge_pages=huge_pages)
vm = test_setup.boot_vm(microvm_factory, guest_kernel_linux_5_10, rootfs)

Expand Down