Skip to content

Conversation

@roypat
Copy link
Contributor

@roypat roypat commented Apr 2, 2025

Follow the official migration guide for upgrading with serde support,
described in 1

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

It was bothering me that there was an empty line.

Signed-off-by: Patrick Roy <[email protected]>
@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.07%. Comparing base (85622c6) to head (4216d12).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/seccompiler/src/lib.rs 0.00% 3 Missing ⚠️
src/firecracker/src/seccomp.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5129      +/-   ##
==========================================
- Coverage   83.09%   83.07%   -0.02%     
==========================================
  Files         250      250              
  Lines       26920    26901      -19     
==========================================
- Hits        22368    22349      -19     
  Misses       4552     4552              
Flag Coverage Δ
5.10-c5n.metal 83.54% <71.42%> (-0.02%) ⬇️
5.10-m5n.metal 83.54% <71.42%> (-0.01%) ⬇️
5.10-m6a.metal 82.70% <71.42%> (-0.03%) ⬇️
5.10-m6g.metal 79.41% <71.42%> (-0.02%) ⬇️
5.10-m6i.metal 83.54% <71.42%> (-0.01%) ⬇️
5.10-m7a.metal-48xl 82.70% <71.42%> (?)
5.10-m7g.metal 79.41% <71.42%> (-0.02%) ⬇️
6.1-c5n.metal 83.58% <71.42%> (-0.02%) ⬇️
6.1-m5n.metal 83.59% <71.42%> (-0.01%) ⬇️
6.1-m6a.metal 82.75% <71.42%> (-0.02%) ⬇️
6.1-m6g.metal 79.41% <71.42%> (-0.02%) ⬇️
6.1-m6i.metal 83.59% <71.42%> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.75% <71.42%> (?)
6.1-m7g.metal 79.41% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Apr 2, 2025
Follow the official migration guide for upgrading with serde support,
described in [1]

[1]: https://github.com/bincode-org/bincode/blob/trunk/docs/migration_guide.md#migrating-with-serde

Signed-off-by: Patrick Roy <[email protected]>
@roypat roypat requested a review from Manciukic April 2, 2025 10:27
@roypat roypat merged commit 6fa2064 into firecracker-microvm:main Apr 2, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants