Skip to content

Conversation

@DakshinD
Copy link
Contributor

@DakshinD DakshinD commented Apr 3, 2025

Changes

Replaced unwraps with map_err to propagate LegacyDeviceError as VmmError::LegacyIOBus to prevent potential panics.

Reason

Resolves TODO Remove these unwraps. see #3273

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@DakshinD DakshinD changed the title Remove unwrap and propagate errors in PIO device manager setup TODO Remove unwrap in PIO device manager setup TODO Apr 3, 2025
@codecov
Copy link

codecov bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (a6d0d93) to head (bf3b182).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5138      +/-   ##
==========================================
+ Coverage   83.02%   83.10%   +0.07%     
==========================================
  Files         250      250              
  Lines       26902    26900       -2     
==========================================
+ Hits        22335    22354      +19     
+ Misses       4567     4546      -21     
Flag Coverage Δ
5.10-c5n.metal 83.59% <100.00%> (+0.03%) ⬆️
5.10-m5n.metal 83.59% <100.00%> (+0.03%) ⬆️
5.10-m6a.metal 82.82% <100.00%> (+0.03%) ⬆️
5.10-m6g.metal 79.38% <0.00%> (+0.01%) ⬆️
5.10-m6i.metal 83.59% <100.00%> (+0.03%) ⬆️
5.10-m7a.metal-48xl 82.80% <100.00%> (?)
5.10-m7g.metal 79.38% <0.00%> (+0.01%) ⬆️
5.10-m7i.metal-24xl 83.54% <100.00%> (?)
5.10-m7i.metal-48xl 83.55% <100.00%> (?)
6.1-c5n.metal 83.63% <100.00%> (+0.02%) ⬆️
6.1-m5n.metal 83.64% <100.00%> (+0.03%) ⬆️
6.1-m6a.metal 82.86% <100.00%> (+0.03%) ⬆️
6.1-m6g.metal 79.38% <0.00%> (+0.01%) ⬆️
6.1-m6i.metal 83.63% <100.00%> (+0.02%) ⬆️
6.1-m7a.metal-48xl 82.85% <100.00%> (?)
6.1-m7g.metal 79.38% <0.00%> (+0.02%) ⬆️
6.1-m7i.metal-24xl 83.64% <100.00%> (?)
6.1-m7i.metal-48xl 83.64% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Replace unwraps with map_err to propagate LegacyDeviceError as
VmmError::LegacyIOBus. This completes a TODO and prevents potential
panics.

Signed-off-by: Dakshin Devanand <[email protected]>
@DakshinD
Copy link
Contributor Author

DakshinD commented Apr 7, 2025

Saw that my commit message was failing checkstyle test. Just amended that and force pushed it over.

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Apr 8, 2025
@roypat roypat enabled auto-merge (rebase) April 9, 2025 14:20
@roypat
Copy link
Contributor

roypat commented Apr 9, 2025

Thanks!

@roypat roypat merged commit e1076e7 into firecracker-microvm:main Apr 9, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants