fix(vmm): Bump snapshot version #5149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To support the snapshot feature for Intel AMX, we changed to use `Xsave` struct instead of `kvm_xsave` struct. We should have bumped the snapshot version. Fixes: 803140d ("feat(vmm): Use structs and methods for KVM_CAP_XSAVE2") Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
zulinx86
added
the
Status: Awaiting author
roypat
approved these changes
Apr 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5149 +/- ##
==========================================
+ Coverage 83.04% 83.10% +0.05%
==========================================
Files 250 250
Lines 26900 26900
==========================================
+ Hits 22340 22354 +14
+ Misses 4560 4546 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes & Reason
To support the snapshot feature for Intel AMX, we changed to use
Xsavestruct instead ofkvm_xsavestruct. We should have bumped the snapshot version.Fixes: 803140d ("feat(vmm): Use structs and methods for KVM_CAP_XSAVE2")
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
[ ] I have updated any relevant documentation (both in code and in the docs)in the PR.
CHANGELOG.md.[ ] If a specific issue led to this PR, this PR closes the issue.Runbook for Firecracker API changes.
integration tests.
[ ] I have linked an issue to every newTODO.rust-vmm.