-
Notifications
You must be signed in to change notification settings - Fork 2.1k
ci: intermittent failures fixes #5159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
203ac8d
to
b336ec9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5159 +/- ##
==========================================
+ Coverage 83.01% 83.06% +0.05%
==========================================
Files 250 250
Lines 26897 26897
==========================================
+ Hits 22328 22342 +14
+ Misses 4569 4555 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
45199aa
to
95fd5f9
Compare
95fd5f9
to
20000f8
Compare
roypat
reviewed
Apr 16, 2025
00085d3
to
6172dd0
Compare
roypat
approved these changes
Apr 23, 2025
6172dd0
to
93e09ce
Compare
kalyazin
reviewed
Apr 24, 2025
Remove assert in the get_stable_rss_mem_by_pid and let it return second rss reading in case if rss did not stabilized after all attempts. This prevents intermittent failures when guest rss is a bit more volatile than we would like. Signed-off-by: Egor Lazarchuk <[email protected]>
93e09ce
to
4ea25e6
Compare
kalyazin
approved these changes
Apr 24, 2025
bchalios
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Fix
Indicates a fix to existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
Fix intermittent failures.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.