Skip to content

Conversation

ShadowCurse
Copy link
Contributor

@ShadowCurse ShadowCurse commented Apr 16, 2025

Changes

  • Update the way we wait for the rss to stabilize in the balloon tests

Reason

Fix intermittent failures.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

Copy link

codecov bot commented Apr 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.06%. Comparing base (c7d443e) to head (4ea25e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5159      +/-   ##
==========================================
+ Coverage   83.01%   83.06%   +0.05%     
==========================================
  Files         250      250              
  Lines       26897    26897              
==========================================
+ Hits        22328    22342      +14     
+ Misses       4569     4555      -14     
Flag Coverage Δ
5.10-c5n.metal 83.56% <ø> (+<0.01%) ⬆️
5.10-m5n.metal 83.56% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 82.79% <ø> (ø)
5.10-m6g.metal 79.34% <ø> (ø)
5.10-m6i.metal 83.56% <ø> (ø)
5.10-m7a.metal-48xl 82.77% <ø> (?)
5.10-m7g.metal 79.34% <ø> (ø)
5.10-m7i.metal-24xl 83.51% <ø> (?)
5.10-m7i.metal-48xl 83.51% <ø> (?)
5.10-m8g.metal-24xl 79.34% <ø> (?)
5.10-m8g.metal-48xl 79.34% <ø> (?)
6.1-c5n.metal 83.61% <ø> (ø)
6.1-m5n.metal 83.60% <ø> (-0.01%) ⬇️
6.1-m6a.metal 82.83% <ø> (ø)
6.1-m6g.metal 79.34% <ø> (ø)
6.1-m6i.metal 83.60% <ø> (ø)
6.1-m7a.metal-48xl 82.82% <ø> (?)
6.1-m7g.metal 79.34% <ø> (ø)
6.1-m7i.metal-24xl 83.61% <ø> (?)
6.1-m7i.metal-48xl 83.61% <ø> (?)
6.1-m8g.metal-24xl 79.34% <ø> (?)
6.1-m8g.metal-48xl 79.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowCurse ShadowCurse force-pushed the balloon_rss branch 3 times, most recently from 45199aa to 95fd5f9 Compare April 16, 2025 11:07
@ShadowCurse ShadowCurse changed the title More minor fixes ci: intermittent failures fixes Apr 16, 2025
@ShadowCurse ShadowCurse marked this pull request as ready for review April 16, 2025 11:08
@ShadowCurse ShadowCurse self-assigned this Apr 16, 2025
@ShadowCurse ShadowCurse added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code labels Apr 16, 2025
@ShadowCurse ShadowCurse force-pushed the balloon_rss branch 3 times, most recently from 00085d3 to 6172dd0 Compare April 23, 2025 14:42
Remove assert in the get_stable_rss_mem_by_pid and let it
return second rss reading in case if rss did not stabilized after
all attempts. This prevents intermittent failures when guest rss
is a bit more volatile than we would like.

Signed-off-by: Egor Lazarchuk <[email protected]>
@bchalios bchalios merged commit 52919c4 into firecracker-microvm:main Apr 24, 2025
6 of 7 checks passed
@ShadowCurse ShadowCurse deleted the balloon_rss branch April 24, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants