Aarch64 better SetOneReg error #5164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop creating PathBuf from a heap allocated constant string. Signed-off-by: Egor Lazarchuk <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5164 +/- ##
==========================================
+ Coverage 83.04% 83.08% +0.04%
==========================================
Files 250 250
Lines 26892 26907 +15
==========================================
+ Hits 22332 22356 +24
+ Misses 4560 4551 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
force-pushed
the
aarch64_better_reg_set_error
branch
2 times, most recently
from
0def782 to
768e357
Compare
roypat
reviewed
Apr 23, 2025
ShadowCurse
force-pushed
the
aarch64_better_reg_set_error
branch
4 times, most recently
from
3beb231 to
88246fb
Compare
Format register id in hex and print the value was attempted to be set. Signed-off-by: Egor Lazarchuk <[email protected]>
If test need to drop fd, it needs to do that before assert checks. Otherwise if assert fails, the IO safety error will occur instead of the assertion error. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
aarch64_better_reg_set_error
branch
from
88246fb to
f90b1ac
Compare
ShadowCurse
added
Status: Awaiting review
roypat
approved these changes
Apr 23, 2025
JackThomson2
approved these changes
Apr 23, 2025
Manciukic
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In case of
SetOneRegerror, format the register id in hex and add a value we tried to set as a part of the error message.Also stop constructing
PathBuffrom constant string.Reason
Better error messages.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.