hiding_ci: sort patch series into directories #5192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are not using the .lore/.mbox options, and I dont see us doing so again in the future either. Signed-off-by: Patrick Roy <[email protected]>
Sorting patch series into directories, so it's easier to swap out individual series without renaming the patch numbers on everything that comes after. Leave gaps in the numbering of the series directories, so that it's easy to potentially insert new series in the middle, if needed. Signed-off-by: Patrick Roy <[email protected]>
roypat
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/secret-hiding #5192 +/- ##
======================================================
Coverage 82.66% 82.66%
======================================================
Files 250 250
Lines 27332 27332
======================================================
Hits 22593 22593
Misses 4739 4739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kalyazin
reviewed
May 6, 2025
kalyazin
approved these changes
May 6, 2025
JackThomson2
approved these changes
May 7, 2025
roypat
merged commit 25b847c
into
firecracker-microvm:feature/secret-hiding
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting patch series into directories, so it's easier to swap out
individual series without renaming the patch numbers on everything that
comes after. Leave gaps in the numbering of the series directories, so
that it's easy to potentially insert new series in the middle, if
needed.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.