Skip to content

test(conftest): dump VM metrics on test failure #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

test(conftest): dump VM metrics on test failure #5205

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a85b41c
test(conftest): dump VM metrics on test failure
kalyazin May 13, 2025
f07ef5c
Merge branch 'main' into ping
kalyazin May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,11 @@ def microvm_factory(request, record_property, results_dir, netns_factory):
report = request.node.stash[PHASE_REPORT_KEY]
if "call" in report and report["call"].failed:
for uvm in uvm_factory.vms:
# This is best effort. We want to proceed even if the VM is not responding.
try:
uvm.flush_metrics()
except: # pylint: disable=bare-except
pass
uvm_data = results_dir / uvm.id
uvm_data.mkdir()
uvm_data.joinpath("host-dmesg.log").write_text(
Expand Down