More extensive logging of integration test failures if uffd is involved #5211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fail to kill firecracker because it already die, we print a hint about the uffd handler being potentially responsible. But this only makes sense if a uffd handler was actually spawned, so restrict printing of the hint to this case. While we're at it, also print the uffd logs in this case, so that the truth of the hint can easily be verified (uffd killed firecracker iff uffd panicked). Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5211 +/- ##
==========================================
+ Coverage 82.88% 82.93% +0.05%
==========================================
Files 250 250
Lines 26936 26936
==========================================
+ Hits 22325 22339 +14
+ Misses 4611 4597 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Move the snapshot creation latency test into test_snapshot_ab.py. It won't be automatically A/B-tested (because pipeline_perf.py refers to specific test names inside this file), but technically it could be. No functional change intended. Doing this because I was getting annoyed at not being able to tab-complete `test_s` into `test_snapshot_ab`. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
test-failure-debug-help
branch
from
655ff65 to
5845843
Compare
We have two places where the test framework dumps a bunch of debug info: When something fails via SSH, and when we fail to kill a microVM because it's already dead. Let's unify both of these to dump the _same_ debug information, by having both call _dump_debug_information (generalized slightly so that it no longer hardcodes "SSH gone wrong" as the error message, and extended to also print uffd logs). Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
test-failure-debug-help
branch
from
5845843 to
74ba11c
Compare
roypat
added
the
Status: Awaiting review
ShadowCurse
approved these changes
May 15, 2025
kalyazin
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print uffd handler logs whenever the test framework dumps debug information in response to an unexpected exception/other failure.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.