fix(test): kill uffd handler when microvm gets killed #5219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop the requirement of having to call spawn_pf_handler() before the call to microvm.restore_from_snapshot() in integration tests, and instead just have restore_from_snapshot() take the name of the uffd handler as an optional keyword argument, and do the spawning. This removes the weird calling convention of calling restore_from_snapshot() without a snapshot parameter (because it was inferred from uffd). Signed-off-by: Patrick Roy <[email protected]>
It's a bit weird to have this attribute set from outside the microvm class. Signed-off-by: Patrick Roy <[email protected]>
By not killing the uffd handler, we are leaking the resources associated with the uffd handler, which can be undesirable and cose gradual slowdown in in snapshot performance tests that restore snapshots using uffd in a loop. Reported-by: Nikita Kalyazin <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5219 +/- ##
==========================================
+ Coverage 82.88% 82.93% +0.05%
==========================================
Files 250 250
Lines 26936 26936
==========================================
+ Hits 22325 22339 +14
+ Misses 4611 4597 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If the FlushMetrics fails during teardown, then this will hide any potential previous failures that might've resulted in Firecracker dying. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
kalyazin
approved these changes
May 21, 2025
Manciukic
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not killing the uffd handler, we are leaking the resources associated
with the uffd handler, which can be undesirable and cose gradual
slowdown in in snapshot performance tests that restore snapshots using
uffd in a loop.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.