New Development Docker Container #5225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
Manciukic,
kalyazin,
pb8o and
xmarcalx
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5225 +/- ##
==========================================
+ Coverage 82.89% 82.94% +0.05%
==========================================
Files 250 250
Lines 26965 26965
==========================================
+ Hits 22353 22367 +14
+ Misses 4612 4598 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
So that we can add it to checkstyle and remove the old pre-commit hook once and for all. Signed-off-by: Patrick Roy <[email protected]>
No particular reason other than it's super easy to rerun a test as many times as you want with it Suggested-by: Riccardo Mancini <[email protected]> Signed-off-by: Patrick Roy <[email protected]>
in preparation for building a new devctr, update our python dependencies. Signed-off-by: Patrick Roy <[email protected]>
This reverts commit 2e994b5. Since iperf 3.18.0 the bug we were running into that caused occasional segfaults has been fixed. Signed-off-by: Patrick Roy <[email protected]>
There's no point in running this in CI, sa by the time a commit reaches the CI its too late to scan for accidentally commited secrets (they'll be out in the open already). So instead, just run it locally when running checkstyle. Signed-off-by: Patrick Roy <[email protected]>
Firecracker stopped supporting kernel 4.14 a while ago, so our minimal supported kernel version these days is 5.10. Update the check in devtool to reflect this. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
zulinx86
previously approved these changes
May 28, 2025
pb8o
previously approved these changes
May 28, 2025
Now that checkstyle runs git-secrets, it is a true superset of the checks that our existing pre-commit hook is running. Since checkstyle is actually what our CI is validating, let's just point the git pre-commit hook instruction to checkstyle, instead of maintaining a separate set of checks somewhere else. Signed-off-by: Patrick Roy <[email protected]>
the release sanity build does not reuse the pre-compiled artifacts (and shouldn't, because doing a cargo build a specific way is part of the release process). So it shouldn't be waiting on the shared build to compiled in buildkite. Signed-off-by: Patrick Roy <[email protected]>
this step reuses the precompiled firecracker binaries, so we needt o pass --no-build to avoid needlessly recompiling firecracker. Signed-off-by: Patrick Roy <[email protected]>
there exists a new container, and old version was 79, so we add one to the number to get 80. Signed-off-by: Patrick Roy <[email protected]>
we picked up a new version of it through the devctr upgrade, and apparently it has _opinions_. Signed-off-by: Patrick Roy <[email protected]>
With the docker update, we picked up a new ubuntu patch version. Signed-off-by: Patrick Roy <[email protected]>
zulinx86
approved these changes
May 28, 2025
pb8o
approved these changes
May 28, 2025
Manciukic
approved these changes
May 28, 2025
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accumulate a few fixes that require a new docker container to be built
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.