Skip to content

fix(test): add sleep to wait for socat spinup in test_tap_offload #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

fix(test): add sleep to wait for socat spinup in test_tap_offload #5228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf7102d
fix(test): add sleep to wait for socat spinup in test_tap_offload
roypat May 28, 2025
96d5276
refactor: use CREATE insteadof OPEN:...,creat for socat
roypat May 28, 2025
7b5c224
fix(test): eliminate sleep-based "wait for vm boot"
roypat May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions tests/integration_tests/functional/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import platform
import re
import resource
import time
from pathlib import Path

import packaging.version
Expand Down Expand Up @@ -1020,12 +1019,9 @@ def test_api_balloon(uvm_nano):
)

# Start the microvm.
test_microvm.add_net_iface()
test_microvm.start()

# Give the balloon driver time to initialize.
# 500 ms is the maximum acceptable boot time.
time.sleep(0.5)

# But updating should be OK.
test_microvm.api.balloon.patch(amount_mib=4)

Expand Down
5 changes: 4 additions & 1 deletion tests/integration_tests/functional/test_net.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,12 @@ def test_tap_offload(uvm_any):
# Start a UDP server in the guest
# vm.ssh.check_output(f"nohup socat UDP-LISTEN:{port} - > {out_filename} &")
vm.ssh.check_output(
f"nohup socat UDP4-LISTEN:{port} OPEN:{out_filename},creat > /dev/null 2>&1 &"
f"nohup socat UDP4-LISTEN:{port} CREATE:{out_filename} > /dev/null 2>&1 &"
)

# wait for socat server to spin up
time.sleep(1)

# Try to send a UDP message from host with UDP offload enabled
vm.netns.check_output(f"python3 ./host_tools/udp_offload.py {vm.ssh.host} {port}")

Expand Down