Skip to content

Conversation

@ShadowCurse
Copy link
Contributor

Changes

New AMI update changed msrs on m7i instance.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@ShadowCurse ShadowCurse self-assigned this Jun 2, 2025
@ShadowCurse ShadowCurse requested a review from zulinx86 June 2, 2025 13:02
@ShadowCurse ShadowCurse added Type: Fix Indicates a fix to existing code Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.94%. Comparing base (455cf98) to head (ebb9ecc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5236      +/-   ##
==========================================
+ Coverage   82.89%   82.94%   +0.05%     
==========================================
  Files         250      250              
  Lines       26966    26966              
==========================================
+ Hits        22353    22367      +14     
+ Misses       4613     4599      -14     
Flag Coverage Δ
5.10-c5n.metal 83.38% <ø> (ø)
5.10-m5n.metal 83.38% <ø> (ø)
5.10-m6a.metal 82.60% <ø> (+<0.01%) ⬆️
5.10-m6g.metal 79.22% <ø> (ø)
5.10-m6i.metal 83.38% <ø> (+<0.01%) ⬆️
5.10-m7a.metal-48xl 82.58% <ø> (?)
5.10-m7g.metal 79.21% <ø> (-0.01%) ⬇️
5.10-m7i.metal-24xl 83.34% <ø> (?)
5.10-m7i.metal-48xl 83.33% <ø> (?)
5.10-m8g.metal-24xl 79.21% <ø> (?)
5.10-m8g.metal-48xl 79.21% <ø> (?)
6.1-c5n.metal 83.43% <ø> (ø)
6.1-m5n.metal 83.43% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 82.64% <ø> (ø)
6.1-m6g.metal 79.22% <ø> (+<0.01%) ⬆️
6.1-m6i.metal 83.41% <ø> (-0.01%) ⬇️
6.1-m7a.metal-48xl 82.63% <ø> (?)
6.1-m7g.metal 79.22% <ø> (ø)
6.1-m7i.metal-24xl 83.44% <ø> (?)
6.1-m7i.metal-48xl 83.44% <ø> (?)
6.1-m8g.metal-24xl 79.20% <ø> (?)
6.1-m8g.metal-48xl 79.21% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShadowCurse ShadowCurse enabled auto-merge (rebase) June 3, 2025 08:23
New AMI update changed msrs.

Signed-off-by: Egor Lazarchuk <[email protected]>
@ShadowCurse ShadowCurse merged commit 0e249fb into firecracker-microvm:main Jun 3, 2025
6 of 7 checks passed
@ShadowCurse ShadowCurse deleted the msr_m7i branch June 3, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants